Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Hover Preview inconsistency: no preview / empty preview for unsupported gradients #3320

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Monday Apr 22, 2013 at 20:01 GMT
Originally opened as adobe/brackets#3535


Hover over each of the following:

.foo {
    background-image: linear-gradient(to right, #333, #CCC);
    background-image: -webkit-radial-gradient(center center, circle contain, black 0%, blue 25%, green 40%, red 60%, purple 80%, white 100%);
    background-image: -moz-radial-gradient(center center, circle contain, black 0%, blue 25%, green 40%, red 60%, purple 80%, white 100%);  
    background-image: radial-gradient(yellow, green); 
    background-image: repeating-linear-gradient(red, blue 20px, red 40px);
    background-image: repeating-radial-gradient(red, blue 20px, red 40px);
}

Result:
Hover preview appears for the first three, but is blank (empty checkerboard). Hover preview does not appear for the last two.

Expected:
Should we be more consistent? It seems better to not show a preview for unsupported cases rather than to show a preview that's incorrect. But how hard is it to detect which cases are supported?

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 22, 2013 at 20:01 GMT


Tentatively assigning to Sprint 24 -- we should at least think about what we want to do about this.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 22, 2013 at 20:03 GMT


Note: I'm going to disable some of the Hover Preview unit tests that depend on the answer to this. We should re-enable them once the expected result is decided.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 22, 2013 at 20:42 GMT


Pull request #3482 may fix this -- still need to verify.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 22, 2013 at 21:15 GMT


Fixed by #3482 -- the two prefixed radial gradients now work, and the remaining cases don't show a preview at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant