Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Hover Preview inconsistency: no preview / empty preview for unsupported gradients #3535

Closed
peterflynn opened this issue Apr 22, 2013 · 4 comments
Assignees
Milestone

Comments

@peterflynn
Copy link
Member

Hover over each of the following:

.foo {
    background-image: linear-gradient(to right, #333, #CCC);
    background-image: -webkit-radial-gradient(center center, circle contain, black 0%, blue 25%, green 40%, red 60%, purple 80%, white 100%);
    background-image: -moz-radial-gradient(center center, circle contain, black 0%, blue 25%, green 40%, red 60%, purple 80%, white 100%);  
    background-image: radial-gradient(yellow, green); 
    background-image: repeating-linear-gradient(red, blue 20px, red 40px);
    background-image: repeating-radial-gradient(red, blue 20px, red 40px);
}

Result:
Hover preview appears for the first three, but is blank (empty checkerboard). Hover preview does not appear for the last two.

Expected:
Should we be more consistent? It seems better to not show a preview for unsupported cases rather than to show a preview that's incorrect. But how hard is it to detect which cases are supported?

@peterflynn
Copy link
Member Author

Tentatively assigning to Sprint 24 -- we should at least think about what we want to do about this.

@peterflynn
Copy link
Member Author

Note: I'm going to disable some of the Hover Preview unit tests that depend on the answer to this. We should re-enable them once the expected result is decided.

@ghost ghost assigned redmunds Apr 22, 2013
peterflynn added a commit that referenced this issue Apr 22, 2013
Update unit tests to use this new, cleaner way of getting info.
Disabled some gradient unit tests where the provider is generating nonsensical
CSS, pending resolution of #3535.
@peterflynn
Copy link
Member Author

Pull request #3482 may fix this -- still need to verify.

@peterflynn
Copy link
Member Author

Fixed by #3482 -- the two prefixed radial gradients now work, and the remaining cases don't show a preview at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants