[CLOSED] Hitting Enter in Replace box should execute replacement?

[core-ai-bot]

Issue by njx
Thursday Apr 24, 2014 at 00:24 GMT
Originally opened as adobe/brackets#7613

---

Not sure why this didn't occur to me before, but I was just using the Find/Replace bar, and I realized that I expected hitting Enter while focus was in the Replace field to actually replace the current match and move to the next one (i.e., the same thing as hitting the Replace button). Right now it just does Find Next, just like hitting Enter in the Find field.

Our current behavior matches ST, but I wonder if changing to make Enter map to Replace while in the Replace box would be a sensible behavior.

[core-ai-bot]

Comment by njx
Thursday Apr 24, 2014 at 00:24 GMT

---

@peterflynn@larz0 what do you think?

[core-ai-bot]

Comment by mackenza
Thursday Apr 24, 2014 at 22:10 GMT

---

@njx I think that the current behavior is consistent with any Find/Replace functionality I have found.

I tried it on:

• Notepad++
• MS Word 2013
• Komodo Edit (which actually doesn't even have a default for when you press enter)
• ST3

I think changing which button is default in a static UI like that is probably not a great user experience. My 2 cents ;)

[core-ai-bot]

Comment by MarcelGerber
Thursday Apr 24, 2014 at 23:03 GMT

---

A thing we could do to improve the UX is to highlight the button that would be "pressed" via Enter. Either via a border, glow or a changed color.

[core-ai-bot]

Comment by njx
Thursday Apr 24, 2014 at 23:10 GMT

---

@mackenza That's fair - if no other app behaves this way then we shouldn't do it. I guess I was thinking of each input field as tied to the buttons beside it, so the "default" button for the field on the left would be the Find Next button, and the "default" button for the field on the right would be Replace. But I agree that it could be just as confusing for people thinking of it differently.

Closing.