[CLOSED] Feature request: zooming by mouse wheel

[core-ai-bot]

Issue by valtlai
Saturday Dec 06, 2014 at 01:31 GMT
Originally opened as adobe/brackets#10099

---

Now when we move to new CEF version, it’s possible to add zooming by mouse wheel feature. (There’s no longer the “ctrl key bug”.)

I tested it with this code:

window.addEventListener("wheel", function(e) {
    if (e.ctrlKey || e.metaKey) { // Windows, OSX (cmd key)
        var direction = (e.deltaY < 0) ? "up" : "down";
        window.console.log("Ctrl + mouse wheel " + direction + " detected");
    }
});

[core-ai-bot]

Comment by TomMalbran
Saturday Dec 06, 2014 at 02:24 GMT

---

That is awesome, and it will be really easy to grab a simple variation of that code that will work in Brackets to change the font-size if you want to give it a try.

[core-ai-bot]

Comment by JeffryBooher
Monday Dec 15, 2014 at 19:37 GMT

---

Closing as this would be a great extension idea!

[core-ai-bot]

Comment by TomMalbran
Monday Dec 15, 2014 at 19:41 GMT

---

@JeffryBooher I don't think that this needs to be an extension. It should be a core feature, and it is in the trello board. The issue was that we couldn't implemented it with the previous versions of cef.

[core-ai-bot]

Comment by JeffryBooher
Monday Dec 15, 2014 at 19:45 GMT

---

@TomMalbran It's likely that we won't get to it soon on the backlog but if someone were to write an extension for it (since the code is mostly written, I suspect@valtlait would do this) then it would be something the core team might bring in as a core extension at some point like we did for the Close Others extension. Otherwise, it's here for users to search for Extension Ideas with the code mostly written, it's just a matter of hooking it up to the Increase/Decrease Font Size API.

@valtlait you should definitely vote on the Trello card.

[core-ai-bot]

Comment by TomMalbran
Monday Dec 15, 2014 at 19:50 GMT

---

@JeffryBooher The card is already there, and it should be a lot easier to just place the code with the rest of the core font size functions. I tried implementing it as a core feature long ago, but I wasn't able to do it using the older cef.

[core-ai-bot]

Comment by JeffryBooher
Monday Dec 15, 2014 at 22:40 GMT

---

@TomMalbran we'd definitely take a pull request to get this in core but couldn't it be done in an extension? There was pr #6854 which had a shell component change but that would no longer work. It may be something an extension author could use as a guide though.

[core-ai-bot]

Comment by TomMalbran
Monday Dec 15, 2014 at 23:24 GMT

---

@JeffryBooher Yes it can. But seems the fix is can probably be done with around 10 lines of code, it makes no sense to create an extension for it. This PR adobe/brackets#3250 tried to implement it, but I had to use a library and couldn't use ctrl+mouse wheel.

[core-ai-bot]

Comment by fgimian
Friday Jun 05, 2015 at 23:20 GMT

---

+1