fix for path to ifcfg-eth0 on centos, to add 'BOOTPROTO=none' flag (dhcp) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI... I'll make sure to review/test this and get it merged in asap... I should have little time today, tomorrow, best guess I'll merge it tuesday if not earlier. |
|
Sorry it took me so long, was a long week. I live in chicago so the cubs wining, let's just say I wasn't on my computer as much as normal weeks |
|
I pushed a gem to rubygems as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using centos7.2, the path to the ifcfg-eth0 file, was using the default ubuntu path "/etc/network/interfaces.d/eth0.cfg", whereas this sits in "/etc/sysconfig/network-scripts/ifcfg-eth0" on centos 7.2. This only affects the dhcp setting, though to be honest, I am not sure that this setting is actually being honoured ( still unsure how the ip address is being configured inside the container. ie the ip address is not configured inside this file ).
Fundamentally, this fix stops an error message from displaying using kitchen on ubuntu with centos lxd containers.
NB also changed setting from "manual" to "none", as this is how kitchen vagrant plugin does it.