Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ish without PHP #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ish without PHP #4

wants to merge 1 commit into from

Conversation

ccoenen
Copy link

@ccoenen ccoenen commented Nov 27, 2012

I put the url-parsing into client-side havascript, ish will now work from any HTTP-Server. It will also work direclty from your filesystem as well.

@coryrylan
Copy link

I did the same thing to get it working with my asp server. Used js to force a iframe update

@ccoenen
Copy link
Author

ccoenen commented Nov 28, 2012

I looked into it, it's very similar, indeed. One thing we're doing differently is the approach to applying the URL. In my case, this change is contained in this line here:
ccoenen@8fe62a8#L1R22

When the page loads, i read the url= variable. This way you a Reload the page and/or deep link to a page inside of ish.
On the other hand, i (intentionally) don't return false in the end, because i use exactly that reload to update the iframe-source. (i basically set the url-variable in the URL and this reloads the page, on load the right iframe-src will be set anyway).

This is not meant as a judgement of either solution. I merely point out the differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants