Merge pull request #25 from bradgarropy/error

🚨 error handling

license

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2019 Brad Garropy
+Copyright (c) 2020 Brad Garropy
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package.json

@@ -1,6 +1,6 @@
 {
     "name": "labman",
-    "version": "0.4.0",
+    "version": "0.4.1",
     "description": "👨🏼‍🔬 github label manager cli",
     "keywords": [
         "github",
@@ -32,15 +32,15 @@
         "start": "node src/cli/index.js"
     },
     "dependencies": {
-        "@octokit/rest": "^16.35.2",
+        "@octokit/rest": "^16.36.0",
         "chalk": "^3.0.0",
         "conf": "^6.2.0",
-        "yargs": "^15.0.2"
+        "yargs": "^15.1.0"
     },
     "devDependencies": {
         "babel-eslint": "^10.0.3",
         "eslint": "^6.8.0",
-        "eslint-config-bradgarropy": "^1.2.0",
+        "eslint-config-bradgarropy": "^1.3.0",
         "eslint-plugin-jsx-a11y": "^6.2.3",
         "eslint-plugin-react": "^7.17.0",
         "eslint-plugin-react-hooks": "^2.3.0",

src/cli/default.js

@@ -1,7 +1,17 @@
 const conf = require("conf")
-const chalk = require("chalk")
-const copy = require("../copy")
-const {createOctokit} = require("../octokit")
+const {
+    errorTokenNotFound,
+    errorInvalidToken,
+    errorRepoNotFound,
+} = require("../errors")
+const {
+    createOctokit,
+    validToken,
+    validRepo,
+    getLabels,
+    deleteLabels,
+    createLabels,
+} = require("../github")
 
 const config = new conf()
 
@@ -21,29 +31,53 @@ const handler = async argv => {
     const {source, destination, labels, clobber} = argv
     const token = config.get("token")
 
+    // validate token
     if (!token) {
-        console.log(
-            `\nYou are not logged in, please run the ${chalk.cyanBright(
-                "login",
-            )} command.\n`,
-        )
+        errorTokenNotFound()
+        return
+    }
+
+    const isValidToken = await validToken(token)
+
+    // validate token
+    if (!isValidToken) {
+        errorInvalidToken()
+        return
+    }
+
+    const isValidSource = await validRepo(source)
 
-        console.log(chalk.cyanBright("labman login <username> <token>\n"))
+    // validate source
+    if (!isValidSource) {
+        errorRepoNotFound(source)
+        return
+    }
+
+    const isValidDestination = await validRepo(destination)
+
+    // validate destination
+    if (!isValidDestination) {
+        errorRepoNotFound(destination)
         return
     }
 
     createOctokit(token)
 
-    try {
-        await copy(source, destination, labels, clobber)
-    } catch (error) {
-        console.log(
-            `\n${chalk.redBright(
-                "Invalid token!",
-            )} Please run the ${chalk.cyanBright("login")} command again.\n`,
-        )
-        console.log(chalk.cyanBright("labman login <username> <token>\n"))
+    // delete existing labels
+    if (clobber) {
+        const oldLabels = await getLabels(destination)
+        await deleteLabels(oldLabels, destination)
     }
+
+    // get new labels
+    const sourceLabels = await getLabels(source)
+
+    const newLabels = labels.length
+        ? sourceLabels.filter(label => labels.includes(label.name))
+        : sourceLabels
+
+    // create new labels
+    await createLabels(newLabels, destination)
 }
 
 module.exports = {

src/cli/login.js

@@ -1,6 +1,7 @@
 const conf = require("conf")
 const chalk = require("chalk")
 const {validToken} = require("../github")
+const {errorLoginFailed} = require("../errors")
 
 const config = new conf()
 
@@ -21,19 +22,22 @@ const handler = async argv => {
     const storedToken = config.get("token")
 
     if (!force && storedToken) {
-        console.log("\nYou are already logged in!\n")
+        console.log()
+        console.log("You are already logged in!")
         return
     }
 
     const valid = await validToken(token)
 
     if (!valid) {
-        console.log(`\n${chalk.redBright("Login failed!")} Please try again.\n`)
+        errorLoginFailed()
         return
     }
 
     config.set({username, token})
-    console.log(chalk.greenBright("\nLogin successful!\n"))
+
+    console.log()
+    console.log(chalk.greenBright("Login successful!"))
 
     return
 }

src/cli/logout.js

@@ -1,11 +1,20 @@
 const conf = require("conf")
+const chalk = require("chalk")
 
 const config = new conf()
 
 const command = "logout"
 const description = "Remove GitHub credentials"
 const builder = {}
-const handler = () => config.clear()
+
+const handler = () => {
+    config.clear()
+
+    console.log()
+    console.log(chalk.greenBright("Logout successful!"))
+
+    return
+}
 
 module.exports = {
     command,

src/errors.js

@@ -0,0 +1,54 @@
+const chalk = require("chalk")
+
+const errorTokenNotFound = () => {
+    const commandText = chalk.cyanBright("login")
+
+    console.log()
+    console.log(`You are not logged in, please run the ${commandText} command.`)
+    console.log()
+    console.log(chalk.cyanBright("labman login <username> <token>"))
+}
+
+const errorInvalidToken = () => {
+    const errorText = chalk.redBright("Invalid token!")
+    const commandText = chalk.cyanBright("login")
+
+    console.log()
+    console.log(`${errorText} Please run the ${commandText} command again.`)
+    console.log()
+    console.log(chalk.cyanBright("labman login <username> <token>"))
+}
+
+const errorLoginFailed = () => {
+    const errorText = chalk.redBright("Login failed!")
+
+    console.log()
+    console.log(`${errorText} Please try again.`)
+}
+
+const errorRepoNotFound = repo => {
+    const repoText = chalk.bold.cyanBright(repo)
+    const errorText = chalk.bold.redBright(
+        `Repository ${repoText} does not exist!`,
+    )
+
+    console.log()
+    console.log(errorText)
+}
+
+const errorLabelExists = label => {
+    const labelText = chalk.bold.cyanBright(label)
+    const errorText = chalk.bold.redBright(
+        ` x Label ${labelText} already exists!`,
+    )
+
+    console.log(errorText)
+}
+
+module.exports = {
+    errorTokenNotFound,
+    errorInvalidToken,
+    errorLoginFailed,
+    errorRepoNotFound,
+    errorLabelExists,
+}