Merge pull request #54 from bradgarropy/bugs

🐞 bugs

package.json

@@ -1,6 +1,6 @@
 {
     "name": "labman",
-    "version": "0.9.1",
+    "version": "0.9.2",
     "description": "👨🏼‍🔬 github label manager cli",
     "keywords": [
         "github",

src/cli/default.js

@@ -1,4 +1,4 @@
-const conf = require("conf")
+const config = require("../config")
 const {repoAutocomplete} = require("../utils")
 const {
     errorTokenNotFound,
@@ -14,8 +14,6 @@ const {
     createLabels,
 } = require("../github")
 
-const config = new conf()
-
 const command = "* <source> <destination> [labels...]"
 const description = "Copy issue labels from one repo to another"
 

src/cli/login.js

@@ -1,10 +1,8 @@
-const conf = require("conf")
 const chalk = require("chalk")
+const config = require("../config")
 const {validToken} = require("../github")
 const {errorLoginFailed} = require("../errors")
 
-const config = new conf()
-
 const command = "login <username> <token>"
 const description = "Persist GitHub credentials"
 

src/cli/logout.js

@@ -1,7 +1,5 @@
-const conf = require("conf")
 const chalk = require("chalk")
-
-const config = new conf()
+const config = require("../config")
 
 const command = "logout"
 const description = "Remove GitHub credentials"

src/config.js

@@ -0,0 +1,10 @@
+const conf = require("conf")
+const {name} = require("../package.json")
+
+const options = {
+    projectName: name,
+}
+
+const config = new conf(options)
+
+module.exports = config

src/tests/cli/default.test.js

@@ -1,4 +1,4 @@
-const conf = require("conf")
+const config = require("../../config")
 const {handler: logoutHandler} = require("../../cli/logout")
 const {handler: defaultHandler} = require("../../cli/default")
 const {
@@ -19,8 +19,6 @@ jest.mock("../../github")
 
 beforeEach(() => logoutHandler())
 
-const config = new conf()
-
 describe("default", () => {
     test("token not found", async () => {
         const args = {

src/tests/cli/login.test.js

@@ -1,4 +1,4 @@
-const conf = require("conf")
+const config = require("../../config")
 const {validToken} = require("../../github")
 const {errorLoginFailed} = require("../../errors")
 const {handler: loginHandler} = require("../../cli/login")
@@ -9,8 +9,6 @@ jest.mock("../../github")
 
 beforeEach(() => logoutHandler())
 
-const config = new conf()
-
 describe("login", () => {
     test("valid token", async () => {
         validToken.mockImplementation(() => true)

src/tests/cli/logout.test.js

@@ -1,8 +1,6 @@
-const conf = require("conf")
+const config = require("../../config")
 const {handler} = require("../../cli/logout")
 
-const config = new conf()
-
 describe("logout", () => {
     test("logout", () => {
         const stored = {

src/tests/config.test.js

@@ -0,0 +1,8 @@
+const config = require("../config")
+const {name} = require("../../package.json")
+
+describe("config", () => {
+    test("config", () => {
+        expect(config).toHaveProperty("path", expect.stringContaining(name))
+    })
+})

src/tests/utils.test.js

@@ -1,8 +1,6 @@
-const conf = require("conf")
+const config = require("../config")
 const {repoPath, repoObject, repoAutocomplete} = require("../utils")
 
-const config = new conf()
-
 describe("repo path", () => {
     test("object", () => {
         const object = {

src/utils.js

@@ -1,4 +1,4 @@
-const conf = require("conf")
+const config = require("./config")
 
 const repoPath = object => {
     const {owner, repo} = object
@@ -34,7 +34,6 @@ const repoAutocomplete = repo => {
         return repo
     }
 
-    const config = new conf()
     const owner = config.get("username")
 
     const autocompleted = `${owner}/${repo}`