Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: parse correlation rules #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnthonyAspen
Copy link

@AnthonyAspen AnthonyAspen commented Apr 21, 2023

What's your thoughts about the correlation rules? I'd like to understand the state of the correlation rules branch. Have you had any plans on finishing it?

@AnthonyAspen AnthonyAspen changed the title WIP: parse correlation rules Draft: parse correlation rules Apr 21, 2023
@bradleyjkemp
Copy link
Owner

Hey @AnthonyAspen, I think in its current state it could probably be merged with only some small tidy up. That would only be for parsing correlation rules though, actually evaluating them is significantly more work.

Is just parsing the correlation rule format useful for you?

@AnthonyAspen
Copy link
Author

AnthonyAspen commented Apr 26, 2023

@bradleyjkemp

actually evaluating them is significantly more work.

Yeah It seems that we may need to refactor the evaluator to a "Matcher" interface, rather than using rules. Additionally, the correlation rules should have a storage interface to allow for state increments and sharing of state, in case one correlation rule relies on another.

Is just parsing the correlation rule format useful for you?

I think it'd be a great start. If you have something in your mind about implementing the correlation rules you can try to summarize it for me and I'll help


In brief, I came up with the idea of parsing the correlation rules after discovering that they have deprecated aggregations and appear to be planning to release the correlation rules in the future. However, the correlation rules are currently only in "version 2.0" of the specification, which makes me concerned that they could make significant changes that would render our (potential) work useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants