Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: major infrastructure upgrade #579

Merged
merged 24 commits into from
Sep 18, 2024
Merged

Conversation

baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Aug 20, 2024

Part of #578

.editorconfig Outdated Show resolved Hide resolved
Comment on lines -1 to -8
# Logs
logs
*.log

# Runtime data
pids
*.pid
*.seed
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will re-create it when needed.

@@ -1 +0,0 @@
* @brafdlog @baruchiro
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this file

Comment on lines +1 to +28
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees:

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

- [x] Changed the `package.json` `repository` to `baruchiro`. Need to
revert before merge.
- [x] Need to check with Google Credentials because they are not
configured in my repo.
- [ ] When using the default config, on Mac, the file exporters get
"readonly filesystem". The problem is they are not failed but running
forever. **I can live with that**
- [ ] run prettier --write on the target branch **some day, in dedicated
commit and PR**

- I removed the `CHANGELOG` file and the updated version from the
`package.json` as suggested
[here](https://semantic-release.gitbook.io/semantic-release/support/faq#making-commits-during-the-release-process-adds-significant-complexity)
- We can continue with the failing pipelines, and not mark them as
required. I commented out the OS matrix for tests to run only on Linux
to save machine time.

#### Tested Platforms

Test this version:
https://github.com/baruchiro/caspion/releases/tag/v1.33.4

- [x] Mac (Apple Silicon): Tested by @baruchiro 
  - [x] CSV: @baruchiro 
  - [x] Excel: @baruchiro 
  - [ ] YNAB
  - [x] Google Sheets: @baruchiro 
- [ ] Mac (Intel Silicon)
  - [ ] CSV
  - [ ] Excel 
  - [ ] YNAB
  - [ ] Google Sheets 
- [ ] Windows
  - [ ] CSV 
  - [ ] Excel 
  - [ ] YNAB
  - [ ] Google Sheets 
- [ ] Linux
  - [ ] CSV 
  - [ ] Excel 
  - [ ] YNAB
  - [ ] Google Sheets
Copy link
Contributor

Please fix the title of this PR.

Examples:

Breaking: I broke something
Fix: fix (fixes #1234)
Update: some packages updates (refs #123)
New: Added a new feature

See more in release.config.js.

@baruchiro baruchiro changed the title Migrate to Vite with upgrades Breaking: major infrastructure upgrade Sep 17, 2024
@baruchiro baruchiro marked this pull request as ready for review September 17, 2024 19:03
@baruchiro baruchiro merged commit 01106b4 into master Sep 18, 2024
9 of 11 checks passed
@baruchiro baruchiro deleted the vite-electron-builder branch September 18, 2024 03:04
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@baruchiro baruchiro restored the vite-electron-builder branch September 18, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants