Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: controller #45

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

rebelonion
Copy link
Contributor

Fixes:

  • Calling onExtensionSelected on disabled extensions other than music
  • SettingTextInput not updating the shown value immediately after setting

Additions

MessagePostClient

  • Allows an extension to hook into mutableMessageFlow to post messages other than errors
  • Interface uses delegate/callback

CloseableClient

  • Allows extensions to close resources the app closes
  • Tied to the player service which should be the last thing running in the app
  • In my case this was useful for closing a websocket that otherwise kept running after the app was closed

ControllerClient

  • Allows an extension to perform actions directly onto the player
  • Uses functions for app->extension communication and callbacks for extension->app communication
  • Nicely documented

examples:

Echo Song Skipper

  • skips songs based off of song or artist name automatically

Echo Remote Control

  • connects to a control app through a websocket server to remotely control playback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant