fix: Improve compatiblity with socket (#1229)

brainboxdotcc · Sep 1, 2024 · 7cdc15a · 7cdc15a
2 parents 5b0b339 + ec9f59f
commit 7cdc15a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/include/dpp/export.h b/include/dpp/export.h
@@ -115,12 +115,10 @@ extern bool DPP_EXPORT validate_configuration();
 
 }
 
-#ifndef _WIN32
-	#define SOCKET int
-#else
-  #ifndef NOMINMAX
-	  #define NOMINMAX
-  #endif
+#ifdef _WIN32
+	#ifndef NOMINMAX
+		#define NOMINMAX
+	#endif
 
 	#include <WinSock2.h>
 #endif

diff --git a/include/dpp/socket.h b/include/dpp/socket.h
@@ -1,18 +1,16 @@
 #pragma once
 
-#ifndef _WIN32
-#ifndef SOCKET
-#define SOCKET int
-#endif
-#endif
-
 namespace dpp
 {
 	/**
 	 * @brief Represents a socket file descriptor.
 	 * This is used to ensure parity between windows and unix-like systems.
 	 */
-	typedef SOCKET socket;
+#ifndef _WIN32
+	using socket = int;
+#else
+	using socket = SOCKET;
+#endif
 } // namespace dpp
 
 #ifndef SOCKET_ERROR