-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breaking): 10.1 - socket engines, refactor, remove dpp::sync #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng. next step integrate https request queues
github-actions
bot
added
documentation
Improvements or additions to documentation
build
Issue or Pull Request related to the build process
code
Improvements or additions to code.
packaging
labels
Nov 13, 2024
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…. todo: refactor this mess
…nd up with dangling ptrs in events
…ng their events rather than prune() loop fix: replace fds that already exist in the set. emplace would fail.
braindigitalis
changed the title
feat: Socket Engines 🚀
feat(breaking): Socket Engines 🚀
Dec 13, 2024
braindigitalis
changed the title
feat(breaking): Socket Engines 🚀
feat(breaking): Socket Engines 🚀 🔌
Dec 13, 2024
braindigitalis
changed the title
feat(breaking): Socket Engines 🚀 🔌
feat(breaking): Socket Engines 🚀🔌
Dec 13, 2024
… we must use a raw ptr :(
braindigitalis
changed the title
feat(breaking): Socket Engines 🚀🔌
feat(breaking): 10.1 - socket engines, refactor, remove dpp::sync
Dec 13, 2024
…e a copy of the cluster ptr, as the client ptr may be invalid by the time the event is triggered (shards now get reallocated)
RealTimeChris
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issue or Pull Request related to the build process
code
Improvements or additions to code.
documentation
Improvements or additions to documentation
packaging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket engines are a high performance abstraction layer for socket events. The end goal of this project is to increase the performance of DPP's internals at scale while using many less threads for the same task. Where currently each shard cluster has its own socket loop, and every request has its own internal socket loop, this will be a thing of the past with one core socket loop per cluster managed by
epoll
,kqueue
orpoll
.The correct socket loop type is selected automatically by cmake.
This project will take a long time to finish (it has already been in progress for a while now) and will be a significant internal change. As far as a library user is concerned there will be minimal change to how the library works if any.
TODO
dpp::sync
Code change checklist
I have ensured that I did not break any existing API calls.This is a breaking new version change.