Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/voice socketengine #1337

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Fix/voice socketengine #1337

merged 3 commits into from
Nov 27, 2024

Conversation

Neko-Life
Copy link
Member

@Neko-Life Neko-Life commented Nov 26, 2024 •
edited
Loading

Changes in this PR

  • Fix voice won't play when joining the first time
  • Fix cluster's engine_thread throwing error on dtor

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Neko-Life Neko-Life self-assigned this Nov 26, 2024
@Neko-Life Neko-Life marked this pull request as draft November 26, 2024 23:11
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Nov 26, 2024
@Neko-Life Neko-Life marked this pull request as ready for review November 26, 2024 23:31
@Neko-Life Neko-Life requested review from braindigitalis, Jaskowicz1 and Mishura4 and removed request for Jaskowicz1 November 26, 2024 23:31
@braindigitalis braindigitalis merged commit 6830a83 into brainboxdotcc:socketengine Nov 27, 2024
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis requested changes

@Mishura4 Mishura4 Awaiting requested review from Mishura4

@Jaskowicz1 Jaskowicz1 Awaiting requested review from Jaskowicz1

Assignees

@Neko-Life Neko-Life

Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neko-Life @braindigitalis