make the parameterised constructors protected so nobody can construct…

… a half-initialised paragraph (this actually found a bug)

include/ssod/paragraph.h

@@ -231,23 +231,6 @@ struct paragraph {
 	 */
 	~paragraph() = default;
 
-	/**
-	 * Construct a paragraph with existing data.
-	 * @note Does not parse the content, this is done asynchronously via the parse method.
-	 * @param data Paragraph content
-	 * @param current Current player
-	 */
-	paragraph(const std::string& data, player& current);
-
-	/**
-	 * Construct a paragraph from paragraph id
-	 * @note Does not parse the content, this is done asynchronously via the parse method.
-	 * @param paragraph_id Paragraph id in database
-	 * @param current Current player
-	 * @param user_id Discord user id
-	 */
-	paragraph(uint32_t paragraph_id, player& current, dpp::snowflake user_id);
-
 	/**
 	 * Given a current paragraph id, return true if the next id is a valid move,
 	 * or false if it isn't. Used as a double check against cheating.
@@ -274,6 +257,24 @@ struct paragraph {
 	 */
 	static dpp::task<paragraph> create(const std::string& data, player& current);
 
+protected:
+	/**
+	 * Construct a paragraph with existing data.
+	 * @note Does not parse the content, this is done asynchronously via the parse method.
+	 * @param data Paragraph content
+	 * @param current Current player
+	 */
+	paragraph(const std::string& data, player& current);
+
+	/**
+	 * Construct a paragraph from paragraph id
+	 * @note Does not parse the content, this is done asynchronously via the parse method.
+	 * @param paragraph_id Paragraph id in database
+	 * @param current Current player
+	 * @param user_id Discord user id
+	 */
+	paragraph(uint32_t paragraph_id, player& current, dpp::snowflake user_id);
+
 	/**
 	 * Parse paragraph content, this may take some time to complete as it has to interpret the content
 	 * and retrieve it from the database.

src/game.cpp

@@ -1359,7 +1359,7 @@ dpp::task<void> continue_game(const dpp::interaction_create_t& event, player p)
 	 * that says "Turn to X" which were an anti-cheat holdover from book-form content.
 	 */
 	while (location.words == 0 && location.navigation_links.size() > 0 && (location.navigation_links[0].type == nav_type_autolink || location.navigation_links[0].type == nav_type_link)) {
-		location = paragraph(location.navigation_links[0].paragraph, p, event.command.usr.id);
+		location = co_await paragraph::create(location.navigation_links[0].paragraph, p, event.command.usr.id);
 		p.paragraph = location.id;
 	}