-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to configure icon prefix #220
Conversation
Good. But why use option for this? |
In our particular use case the project is not using Glyphicons at all. Instead FontAwesome is used with the prefix set to "icon" instead of "fa". By adding that option to the configuration we only have to specify the prefix change once instead of every time a call is made to the "icon" helper.
Oh yeah, I had intended to comment on that, the @Alpha deps were failing to resolve. If it was just an error on my end I can revert those changes just let me know. |
I understood about option. May be combine it with twig icon filter parameter? It be more usefull. About knp-menu-bundle I test it today. |
Thanks for the PR, I will merge it, but could you set the KnpMenu dependencies back to |
Done, any idea why it would cause issues though? Also, do you wan't me to update any of the docs with this? |
Hm... for me:
Work fine. May be create test for this later? |
add option to configure icon prefix
Does it solve #160 ? |
I noticed that you hadn't added support for customizing the icon-set yet and I figured I'd take a crack at it since I needed to support FontAwesome for a project anyway.
It seemed to make the most sense to just allow configuration of the icon prefix rather than hardcoding library support.
@florianeckerstorfer Do you have any issues with this implementation or anything you want added/changed?