Fixing placeholder application in inline forms #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code triggers `label => false` in `inline` forms to use `name|humanize` as the placeholder. This is wrong and if label is set explicitly to `false` it should trigger no placeholder. This fix adds the extra check to avoid this behavior.
florianeckerstorfer
pushed a commit
that referenced
this pull request
Jun 15, 2014
Fixing placeholder application in inline forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code triggers
label => falseininlineforms to usename|humanizeas the placeholder.This is wrong and if label is set explicitly to
falseit should trigger no placeholder.This fix adds the extra check to avoid this behavior.
Should this be applied to any other branches?