Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot import name 'Script' from 'redis.client' with 'redis-4.1.0' #552

Closed
wy-z opened this issue Dec 27, 2021 · 2 comments
Closed

Cannot import name 'Script' from 'redis.client' with 'redis-4.1.0' #552

wy-z opened this issue Dec 27, 2021 · 2 comments
Assignees
@brainix
Labels
bug dependencies Pull requests that update a dependency file

Comments

@wy-z
Copy link

wy-z commented Dec 27, 2021 •
edited
Loading

Describe the bug
Cannot import name 'Script' from 'redis.client' with 'redis-4.1.0'

To Reproduce
Use pottery with 'redis-4.1.0'

Additional context
'redis.client.Script' has been removed.
Look at the following code
redis/redis-py@12f45ee#diff-3161b005adfa1f5266a9736bffb5ede9d14e2ab40937cb241bc16ca5647df79d

redis/redis-py#1748
@jasonTu
Copy link

jasonTu commented Dec 27, 2021

Met the same issue too.

@brainix brainix self-assigned this Dec 27, 2021
@brainix brainix added bug dependencies Pull requests that update a dependency file labels Dec 27, 2021
brainix added a commit that referenced this issue Dec 27, 2021
@brainix
Fix #552: Import Script from the correct place
89cc53e
@brainix
Copy link
Owner

brainix commented Dec 27, 2021

Thanks to your detailed bug report, @wy-z, the fix was easy! And thanks for confirming, @jasonTu.

I've just released Pottery 2.2.2 which includes the bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brainix brainix

Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brainix @jasonTu @wy-z