Add nginx forwarding #133
Draft
Add nginx forwarding #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into add-nginx-forwarding
bendhouseart
commented
Sep 18, 2024
dev.sh
Outdated
Comment on lines
20
to
21
| (cd api && npm install -g npm@9.5.1) | ||
| (cd ui && npm install -g npm@9.5.1) | ||
| (cd api && npm install) | ||
| (cd ui && npm install) |
There was a problem hiding this comment.
@dlevitas @anibalsolon Mac is such a nightmare, I had to mess with this stuff and disable husky to get this running on my x86 machine (old intel mac pro). As I mention in the PR description this should probably be undone, will do so once I've got https working properly.
… into add-nginx-forwarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds nginx forwarding so that a local/on-prem deployment can behave a bit better.
TODO:
@dlevitas I had to mess with vite and some other changes you recently made to make this behave on Mac, I'm not sure if it's worth adding in some logic to use/not use parts of the config if it's being built on Mac at all. In all honesty, it's probably best to undo those changes, but idk.