Add SESSION TIMEOUT support and missing defer rows.Close() #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianCzoch
approved these changes
Dec 23, 2022
robertomczak
changed the title
robertomczak
force-pushed
the
AI-1698
branch
from
e3af513 to
b022958
Compare
robertomczak
force-pushed
the
AI-1698
branch
from
b022958 to
9d2d703
Compare
marekpp
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
adds support of SESSION TIMEOUT user settinghttps://docs.aws.amazon.com/redshift/latest/dg/r_ALTER_USER.html
adds missing rows.Close() in order to avoid condition where connection is kept open and idle due to not closed result set.
With larger set of in this case grants it could result with threads waiting for result set cleanup that never occurred.