Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require password for superuser at plan phase #39

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

winglot
Copy link
Member

@winglot winglot commented Dec 30, 2021

Add validation of password field for the superuser. Will now error on plan phase when superuser = true and password field was omitted.

#37

@winglot winglot merged commit aaa4629 into master Dec 30, 2021
@winglot winglot deleted the feat/superuser-password-validation branch December 30, 2021 09:51
@mtesch-um
Copy link
Contributor

mtesch-um commented Dec 30, 2021

Now the user can't import any superusers without managing their passwords with terraform :( I think that might be a common use case.

I guess personally if I had to choose between the two behaviors: 1. erroring only on apply vs. 2. not being able to import a superuser without having its password in tf state, I would choose evil 1. 😬

@mtesch-um
Copy link
Contributor

This

resource "redshift_user" "user" {
  name      = "user"
  superuser = false
}

causes: │ "superuser": all of password,superuser must be specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants