Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update optimizer #451

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Update optimizer #451

merged 3 commits into from
Aug 21, 2023

Conversation

yygf123
Copy link
Contributor

@yygf123 yygf123 commented Aug 21, 2023

Environment

  • OS: Windows 10
  • Python: 3.9
  • CPU: AMD Ryzen 7 4800H with Radeon Graphics
  • GPU: NVIDIA GeForce RTX 2060

Content

  1. Update optimizer.py and scheduler.py to support learning rate modification.
  2. Change some schedulers's name. For example, change the name of ExponentialDecay to ExponentialDecayLR.
  3. Create test_ModifyLr.py to test learning rate modification.
  4. Update the document "optimizers.ipynb".

Checklist

  • The automatic actions have passed.

chaoming0625
chaoming0625 requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please reformat the codes.

chaoming0625
chaoming0625 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@chaoming0625 chaoming0625 merged commit 25502e8 into brainpy:master Aug 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoming0625 chaoming0625 chaoming0625 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yygf123 @chaoming0625