fix bugs in truncated_normal; add TruncatedNormal init. #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoming0625
requested changes
Jan 1, 2024
There was a problem hiding this comment.
I think we should first merge #574, then merge the latest changes, and finnally the brainpy.init.TruncatedNormal should work.
Moreover, please add the new APIs into the bainpy.intialize module and corresponding doc in docs\apis\initialize.rst
|
@chaoming0625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
random.truncated_normalis not properly truncated.TruncatedNormalinitializationbug fix is a re-implementation of PR#574, also fix bugs therein.
Passed local test.
Types of changes
Checklist
Other information