Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
truncated_normal
inbrainpy.math.random
callsjr.uniform
to sample from a uniform distribution and then inverse the cdf to get truncated values.jr.uniform
samples from a closed interval. Whenlower
orupper
takes inf values and whenjr.uniform
sampled an extreme value, the inverse cdf would have inf values, which result in underflow values after clipping.Fix: subtract and add a small value to
minval
andmaxval
arguments ofjr.uniform
.How Has This Been Tested
Types of changes
Checklist
Other information