Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[math] Refactor taichi operators #598

Merged
merged 27 commits into from
Jan 29, 2024
Merged

[math] Refactor taichi operators #598

merged 27 commits into from
Jan 29, 2024

Conversation

Routhleck
Copy link
Collaborator

Add dnn.linear taichi implmentation

Routhleck
Routhleck commented Jan 25, 2024
View reviewed changes
Copy link
Collaborator Author

@Routhleck Routhleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to pull request

@Routhleck Routhleck marked this pull request as ready for review January 25, 2024 09:35
chaoming0625
chaoming0625 requested changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by the code in this PR. The discussion may be needed.

@Routhleck Routhleck changed the title [dnn] Add dnn.linear taichi implmentation [dnn] Refactor taichi operators Jan 27, 2024
@Routhleck Routhleck marked this pull request as draft January 27, 2024 06:00
@Routhleck
Copy link
Collaborator Author

Routhleck commented Jan 28, 2024 •
edited
Loading

Replace with taichi op

  • event csr matvec
    cpu default: taichi
    gpu default: brainpylib(cusparse)
  • csr matvec
    cpu default: taichi
    gpu default: taichi
  • jitconn event matvec
    cpu default: taichi
    gpu default: taichi(outdim parallel=False) brainpylib(outdim parallel=True)
  • jitconn matvec
    cpu default: taichi
    gpu default: taichi(outdim parallel=False) brainpylib(outdim parallel=True)

@Routhleck Routhleck marked this pull request as ready for review January 28, 2024 15:09
@Routhleck Routhleck changed the title [dnn] Refactor taichi operators [math] Refactor taichi operators Jan 28, 2024
@Routhleck
Copy link
Collaborator Author

Set all operators to using taichi kernel defaultly

chaoming0625
chaoming0625 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chaoming0625 chaoming0625 merged commit 7e8dd81 into master Jan 29, 2024
29 of 31 checks passed
@chaoming0625 chaoming0625 deleted the add-dnn-linear-taichi branch January 29, 2024 15:15
@Routhleck Routhleck added enhancement New feature or request brainpy.math issue belongs to brainpy.math module labels Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoming0625 chaoming0625 chaoming0625 approved these changes

Assignees
No one assigned
Labels
brainpy.math issue belongs to brainpy.math module enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Routhleck @chaoming0625