Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to get brain entropy version #636

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

Edouard2laire
Copy link
Contributor

@Edouard2laire Edouard2laire commented Aug 9, 2023

This adds the function to read the VERSION.txt file to get the version number of the toolbox (added here: multifunkim/best-brainstorm#8)

When looking at the installed plugin, shouldn't this number appear instead of 'Github-master' ?
edit: Done here 6c3017b

Screenshot from 2023-08-09 13-45-46

The following code

>> PluginDescription  = bst_plugin('GetInstalled', 'brainentropy');
>> PluginDescription.GetVersionFcn()

return

'2.7.3'

Note: this is ready for review :)

@rcassani
Copy link
Member

The version in the PlugDesc comes from the plugin.mat file which is supposed to be filled by GetVersionFcn at installation. But if for some reason it is empty, GetVersionFcn is now used (for loaded or unloaded plugins).

Let me know if you want to add something else to the PR.
Otherwise, it looks good and ready to be merged!

@Edouard2laire
Copy link
Contributor Author

looks good to me. Thanks :)

@rcassani rcassani merged commit 2c17bcb into brainstorm-tools:master Aug 10, 2023
@Edouard2laire Edouard2laire deleted the best-version branch August 10, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants