Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android 15 #127

Merged
merged 13 commits into from
Oct 3, 2024
Merged

Support Android 15 #127

merged 13 commits into from
Oct 3, 2024

Conversation

sshropshire
Copy link
Contributor

Summary of changes

  • Add support for Android 15

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner September 23, 2024 15:22
uses: actions/setup-java@v2
with:
java-version: '8'
java-version: '17'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Java 17 required to compile card form now? Is this a breaking change then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be I don't see an explicit Java version specified in the build.gradle. I updated the build.gradle file to make it explicit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm trying to understand - can we support Android 15 without bumping the java version? Or are we doing a major version of card form here? I more so am concerned that this change will force a major version in drop-in which I don't think we want to do yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh got it yeah I forgot DropIn doesn't use v5 yet. AGP uses JDK 17 to build, but we can set sourceCompatability to Java 8 and it should be fine.

@@ -26,18 +25,23 @@ android {
textOutput 'stdout'
}

compileOptions {
sourceCompatibility versions.javaSourceCompatibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Java 8 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's 8 I made the change here: b0d4a3d

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Koop <skoop@paypal.com>
@sshropshire sshropshire merged commit 3228e03 into master Oct 3, 2024
2 checks passed
@sshropshire sshropshire deleted the support_android_15 branch October 3, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants