Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venmo - Add deep link fallback #1237

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Venmo - Add deep link fallback #1237

merged 1 commit into from
Dec 10, 2024

Conversation

tdchow
Copy link
Collaborator

@tdchow tdchow commented Dec 10, 2024

Summary of changes

  • Add deep link fallback to Venmo
  • Fix demo app bug where a path was added to the app link URL

Tested Scenarios:

  • App link
  • Deep link when "Open supported links" is disabled
  • Null deep link when "Open supported links" is disabled returns an error

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@tdchow tdchow marked this pull request as ready for review December 10, 2024 17:16
@tdchow tdchow requested a review from a team as a code owner December 10, 2024 17:16
@@ -37,6 +37,7 @@

<data android:scheme="https" />
<data android:host="mobile-sdk-demo-site-838cead5d3ab.herokuapp.com" />
<data android:pathPrefix="/braintree-payments" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /braintree-payments path was added to the app link URL at some point which broke the app link flow in the demo app.

@tdchow tdchow merged commit 7fc4f26 into main Dec 10, 2024
3 checks passed
@tdchow tdchow deleted the venmo-deep-link-fallback branch December 10, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants