Add Shopper Session ID param #1241
Conversation
| /** | ||
| * Used for sending Shopper Insights session ID provided by merchant to FPTI | ||
| */ | ||
| private var shopperSessionId: String? = null |
There was a problem hiding this comment.
Should we save this in a repository singleton outside of the Client class? Maybe a PayPalRepository that holds all PayPal specific values.
There was a problem hiding this comment.
I considered adding it to the AnalyticsParamRepository but since it is passed in by the merchant at each step there didn't seem much value there and it seemed a little confusing that we don't do that for any other general analytics event params. Open to a new param repository or adding it to the existing one if folks think that would be more helpful!
There was a problem hiding this comment.
Ah gotcha. That makes sense 👍
| @@ -17,6 +17,7 @@ import androidx.annotation.RestrictTo | |||
| * the experiment, as a JSON string, that the merchant sent to the us. | |||
| * @property paymentMethodsDisplayed A ShopperInsights module specific event that indicates the | |||
| * order of payment methods displayed to the shopper by the merchant. | |||
| * @property shopperSessionId A ShopperInsights session ID provided by the merchant | |||
There was a problem hiding this comment.
nit: do we want to match iOS?
/// The Shopper Insights customer session ID created by a merchant's server SDK or graphQL integration.
Summary of changes
sessionIdfor shopper insightsshopper_session_idFPTI tag to be used specifically for shopper insights and related payment flowsshopper_session_idis getting to FPTI as expectedshopper_session_idto FPTI braintree_ios#1485Checklist
Authors
@sarahkoop