Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove paymentMethodsDisplayed #1249

Merged

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Remove paymentMethodsDisplayed - no longer needed for v1.5 of Shopper Insights

Checklist

  • [ ] Added a changelog entry
  • [ ] Relevant test coverage
  • [ ] Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@jaxdesmarais

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner January 7, 2025 16:58
…lyticsEventParams.kt

Co-authored-by: Sarah Koop <skoop@paypal.com>
@saperi22
Copy link
Contributor

saperi22 commented Jan 8, 2025

@jaxdesmarais do we want to update the docs for the sendPayPalPresentedEvent to say that it is no longer required? I don't think we'd want to disturb the signature to preserve backwards compatibility.

@jaxdesmarais
Copy link
Contributor Author

@jaxdesmarais do we want to update the docs for the sendPayPalPresentedEvent to say that it is no longer required? I don't think we'd want to disturb the signature to preserve backwards compatibility.

For shopper insights we have updated all of the signatures to remove this property, but never cleaned up the FPTI tag. We have agreed with product to make these breaking changes per our docstrings and tags, so will not maintain backwards compatibility once this is released:

* Note: **This feature is in beta. It's public API may change in future releases.**
*/
@ExperimentalBetaApi

@jaxdesmarais jaxdesmarais merged commit 9e9a402 into shopper-insights-rp2-feature Jan 9, 2025
3 checks passed
@jaxdesmarais jaxdesmarais deleted the remove-paymentMethodsDisplayed branch January 9, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants