Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding null check at the beginning of sanitizeUrl function #57

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix: adding null check at the beginning of sanitizeUrl function #57

merged 3 commits into from
Jul 18, 2023

Conversation

oscarleonnogales
Copy link
Contributor

@oscarleonnogales oscarleonnogales commented Jul 17, 2023 •
edited
Loading

Summary

  • Add null check to the beginning of sanitizeUrl function. Fixes issue (#54)
  • Created variable for "about:blank" URL

For internal tracking, DTBTSDK-2818

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@oscarleonnogales oscarleonnogales requested a review from a team as a code owner July 17, 2023 20:37
cgdibble
cgdibble approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@cgdibble cgdibble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 super clean. I'm a big fan of a local const being exported and used in the tests!

jplukarski
jplukarski approved these changes Jul 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@oscarleonnogales oscarleonnogales merged commit 9f3ca15 into main Jul 18, 2023
1 check passed
@oscarleonnogales oscarleonnogales deleted the DTBTSDK-2818 branch July 18, 2023 15:21
@oscarleonnogales oscarleonnogales mentioned this pull request Jul 18, 2023
Closed
@jameswragg jameswragg mentioned this pull request Aug 1, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgdibble cgdibble cgdibble approved these changes

@jplukarski jplukarski jplukarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarleonnogales @cgdibble @jplukarski