Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LI-38822 Handle Whitespace Escapes #73

Merged
merged 5 commits into from
May 14, 2024
Merged

LI-38822 Handle Whitespace Escapes #73

merged 5 commits into from
May 14, 2024

Conversation

ibooker
Copy link
Contributor

@ibooker ibooker commented May 8, 2024 •
edited
Loading

Add logic for sanitize-url to handle white space escapes and encoded whitespace, such as:

  • \n
  • \r
  • \t

Example:

  • input: javascrip\nt:alert('whitespace')
  • output: about:blank

@ibooker ibooker requested a review from a team as a code owner May 8, 2024 20:50
mikenichols
mikenichols approved these changes May 13, 2024
View reviewed changes
Copy link

@mikenichols mikenichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ibooker ibooker merged commit 6f474fc into main May 14, 2024
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenichols mikenichols mikenichols approved these changes

@jplukarski jplukarski jplukarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibooker @mikenichols @jplukarski