Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: configurable python (OpenAI) client #102

Merged
merged 9 commits into from
Dec 13, 2024
Merged

feature: configurable python (OpenAI) client #102

merged 9 commits into from
Dec 13, 2024

Conversation

ibolmo
Copy link
Contributor

@ibolmo ibolmo commented Dec 12, 2024

All public interfaces that work with OpenAI transitively now have an optional AutoEvalCient client option. If not provided, we'll prepare and handle the OpenAI client as we do already.

At the moment you need to pass the client in each call, but in a follow-up commit you'll be able to set it globally.

All public interfaces that work with OpenAI transitively
now has an optional AutoEvalCient client option. If not provided,
we'll prepare and handle the OpenAI client as we do already.

At the moment you need to pass the client in each call, but
in a follow-up commit you'll be able to set it globally.
Copy link

github-actions bot commented Dec 12, 2024

Braintrust eval report

Autoevals (bra-1846-1734050368)

Score Average Improvements Regressions
NumericDiff 75.9% (+0pp) - -
Duration 1.53s (-0.02s) 34 🟢 68 🔴
Llm_duration 1.56s (+0.02s) - 2 🔴
Prompt_tokens 279.22tok (+0tok) - -
Completion_tokens 17.85tok (+0tok) - -
Total_tokens 297.07tok (+0tok) - -
Estimated_cost 0$ (0$) - -

@ibolmo ibolmo marked this pull request as draft December 12, 2024 03:51
@ibolmo ibolmo self-assigned this Dec 12, 2024
Copy link
Contributor

@ankrgyl ankrgyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

py/autoevals/oai.py Outdated Show resolved Hide resolved
@ibolmo ibolmo marked this pull request as ready for review December 12, 2024 19:44
@ibolmo ibolmo changed the title feature: configurable (OpenAI) client feature: configurable python (OpenAI) client Dec 12, 2024
@ibolmo
Copy link
Contributor Author

ibolmo commented Dec 12, 2024

This will supersede #98

@ibolmo ibolmo merged commit a3ca1cf into main Dec 13, 2024
8 checks passed
@ibolmo ibolmo deleted the bra-1846 branch December 13, 2024 00:39
Copy link

github-actions bot commented Dec 13, 2024

Braintrust eval report

Autoevals (main-1734050408)

Score Average Improvements Regressions
NumericDiff 75.9% (+0pp) - -
Duration 1.55s (+0.02s) 67 🟢 35 🔴
Llm_duration 1.55s (-0.01s) 1 🟢 1 🔴
Prompt_tokens 279.22tok (+0tok) - -
Completion_tokens 17.85tok (+0tok) - -
Total_tokens 297.07tok (+0tok) - -
Estimated_cost 0$ (+0$) - -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants