-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: configurable python (OpenAI) client #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All public interfaces that work with OpenAI transitively now has an optional AutoEvalCient client option. If not provided, we'll prepare and handle the OpenAI client as we do already. At the moment you need to pass the client in each call, but in a follow-up commit you'll be able to set it globally.
Braintrust eval reportAutoevals (bra-1846-1734050368)
|
ankrgyl
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ibolmo
changed the title
feature: configurable (OpenAI) client
feature: configurable python (OpenAI) client
Dec 12, 2024
This will supersede #98 |
ankrgyl
approved these changes
Dec 12, 2024
Braintrust eval report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All public interfaces that work with OpenAI transitively now have an optional AutoEvalCient client option. If not provided, we'll prepare and handle the OpenAI client as we do already.
At the moment you need to pass the client in each call, but in a follow-up commit you'll be able to set it globally.