Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity tweak on EvaluatingChatAssistant #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clarity tweak on EvaluatingChatAssistant #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01fd216
Update EvaluatingChatAssistant.ipynb
edspencer Dec 13, 2024
ba29a14
PR feedback
edspencer Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@
}
],
"source": [
"//NOTE we added chat_history here",
edspencer marked this conversation as resolved.
Show resolved Hide resolved
"const experimentData = dataset.map((data) => ({\n",
" input: { input: data.input, chat_history: data.chat_history },\n",
" expected: data.expected,\n",
Expand Down Expand Up @@ -520,7 +521,7 @@
"source": [
"We update the parameter to the task function to accept both the `input` string and the `chat_history` array and add the `chat_history` into the messages array in the chat completion request, done here using the spread `...` syntax.\n",
"\n",
"We also need to update the `experimentData` and `Factual` function parameters to align with these changes."
"Please note that we changed the format of `experimentData`, and the parameters to the `Factual` function to align with these changes."
edspencer marked this conversation as resolved.
Show resolved Hide resolved
]
},
{
Expand Down