Prevent panics on client-cert authenticated requests #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
reviewed
Jul 19, 2021
| @@ -42,19 +42,20 @@ func NewDelegatingAuthenticator(client authenticationclient.TokenReviewInterface | |||
| p *dynamiccertificates.DynamicFileCAContent | |||
There was a problem hiding this comment.
does this still need to be declared up here?
There was a problem hiding this comment.
it's used in the return value
deads2k
reviewed
Jul 19, 2021
| TokenAccessReviewClient: client, | ||
| APIAudiences: authenticator.Audiences(authn.Token.Audiences), | ||
| } | ||
|
|
||
| if len(authn.X509.ClientCAFile) > 0 { | ||
| p, err = dynamiccertificates.NewDynamicCAContentFromFile("client-ca", authn.X509.ClientCAFile) |
|
Fix for CI failure is in #133 |
Setting a nil-value typed object in the `DelegatingAuthenticatorConfig` will cause the generic logic to still evaluate is as non-nil since Golang does not consider `(*type)(nil)` as `nil` in `== nil` comparison unless `type == nil`, too. This leads to a setup of an x509 authenticator that attempts to call `VerifyOptions` on a nil object.
|
I rebased the PR myself as @stlaz is on vacations :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a nil-value typed object in the
DelegatingAuthenticatorConfigwill cause the generic logic to still evaluate is as non-nil since
Golang does not consider
(*type)(nil)asnilin== nilcomparisonunless
type == nil, too.This leads to a setup of an x509 authenticator that attempts to call
VerifyOptionson a nil object.fixes #131