-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move --upstream-force-h2c out of --insecure-listen-address #139 #140
chore: move --upstream-force-h2c out of --insecure-listen-address #139 #140
Conversation
Upstream-force-h2c is a flag for upstream, while insecure-listen-address is for the proxy endpoint. Both can work separately. One use case is having a secure terminating endpoint with kube-rbac-proxy while having an insecure upstream. Signed-off-by: Andy Librian <andylibrian@gmail.com>
@andylibrian loooks great so far 👍 do you think it Is feasible to add an e2e test for this? Potentially we could contribute to https://github.com/brancz/prometheus-example-app to allow h2c requests. |
I'm ok to add a test. This would be a new directory (something like |
@andylibrian that would be perfect, yes |
ref: brancz/kube-rbac-proxy#140 Signed-off-by: Andy Librian andylibrian@gmail.com
@s-urbaniak I opened a PR in the example repo: brancz/prometheus-example-app#11 Do you mind taking a look? |
Merged and pushed the new example app version |
@brancz thank you! 🙏 @andylibrian how do you feel finalizing this here? :) |
Thanks @brancz! @s-urbaniak, I'm still keen to add the test, hopefully next week |
@andylibrian perfect, thank you and no rush! 🙏 |
@s-urbaniak I've added e2e test for h2c upstream. Do you mind taking a look? |
The failing golint seems to be flakey:
Can we restart it? |
@andylibrian i didn't do a thorough review yet, but do you mind fixing the linting issue first? |
Signed-off-by: Andy Librian <andylibrian@gmail.com>
@s-urbaniak I ran |
@andylibrian thank you! We will have a look and I'll merge once e2e is green 👍 |
@s-urbaniak Thank you for merging it! |
Upstream-force-h2c is a flag for upstream, while insecure-listen-address is for the proxy endpoint. Both can work
separately. One use case is having a secure terminating endpoint with kube-rbac-proxy while having an insecure upstream.
Signed-off-by: Andy Librian andylibrian@gmail.com
ref: #139