chore: move --upstream-force-h2c out of --insecure-listen-address #139

[andylibrian]

Upstream-force-h2c is a flag for upstream, while insecure-listen-address is for the proxy endpoint. Both can work
separately. One use case is having a secure terminating endpoint with kube-rbac-proxy while having an insecure upstream.

Signed-off-by: Andy Librian andylibrian@gmail.com

ref: #139

[s-urbaniak]

@andylibrian loooks great so far 👍 do you think it Is feasible to add an e2e test for this? Potentially we could contribute to https://github.com/brancz/prometheus-example-app to allow h2c requests.

[andylibrian]

I'm ok to add a test. This would be a new directory (something like h2c-upstream) along with existing basics, tokenrequest, etc. Sounds good to you?

[s-urbaniak]

@andylibrian that would be perfect, yes

[andylibrian]

@s-urbaniak I opened a PR in the example repo: brancz/prometheus-example-app#11

Do you mind taking a look?

[brancz]

Merged and pushed the new example app version

[s-urbaniak]

@brancz thank you! 🙏 @andylibrian how do you feel finalizing this here? :)

[andylibrian]

Thanks @brancz!

@s-urbaniak, I'm still keen to add the test, hopefully next week

[s-urbaniak]

@andylibrian perfect, thank you and no rush! 🙏

[andylibrian]

@s-urbaniak I've added e2e test for h2c upstream. Do you mind taking a look?

[andylibrian]

The failing golint seems to be flakey:

run golangci-lint
  Running [/home/runner/golangci-lint-1.42.1-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

Can we restart it?

[s-urbaniak]

@andylibrian i didn't do a thorough review yet, but do you mind fixing the linting issue first?

[andylibrian]

@s-urbaniak I ran golangci-lint run locally on this branch and it passed. I think the build was flaky. I was requesting to restart the build manually, but I went ahead with force pushing this branch hoping that it triggered another build.

[s-urbaniak]

@andylibrian thank you! We will have a look and I'll merge once e2e is green 👍

[andylibrian]

@s-urbaniak Thank you for merging it!