-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use supported apiVersion for deployment and authorization #150
fix: use supported apiVersion for deployment and authorization #150
Conversation
From k8s version 1.22 the following apiVersions[1][2] are no longer served. Hence the PR introduces the following changes * replace `extensions/v1beta1` with `apps/v1` * replace `authorization.k8s.io/v1beta1` with `authorization.k8s.io/v1` [1]: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#tokenreview-v122 [2]: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#deployment-v116 Signed-off-by: Sunil Thaha <sthaha@redhat.com>
b4f9509
to
ef00e25
Compare
cc: @paulfantom @jan--f @s-urbaniak , could you please take a look? |
Thank you for the effort! Why did you remove the non-resource example? |
@s-urbaniak @ibihim I can submit a separate cleanup PR but since I have touched the examples, I thought I will clean up the duplicate In other words, after fixing the examples/non-resource-url/non-resource-url, and correcting the `kube-rbac-proxy version ❯ diff examples/non-resource-url examples/non-resource-url/non-resource-url Only in examples/non-resource-url: non-resource-url
diff examples/non-resource-url/README.md examples/non-resource-url/non-resource-url/README.md
5c5
< RBAC differentiates in two types, that need to be authorized, resources and non-resources. A resource request authorization, could for example be, that a requesting entity needs to be authorized to perform the `get` action on a particular Kubernetes Deployment. A non-resource authorization validates, that an entity is authorized to request a bare URL.
---
> RBAC differentiates in two types, that need to be authorized, resources and non-resoruces. A resource request authorization, could for example be, that a requesting entity needs to be authorized to perform the `get` action on a particular Kubernetes Deployment. A non-resource authorization validates, that an entity is authorized to request a bare URL.
which is a typo in |
@sthaha, I think it is amazing, that you continue to support the repository beyond the version bump, but could you add the 3 files back for this PR? +73 -325 << 3 files get deleted: |
As @sthaha already pointed out, the removed files seem to have been added erroneously and only differ in that they have a few typos in them compared the actual example files. So 👍 for removing those. |
Ah, sorry. My bad. I completely misunderstood the reasoning. /lgtm I actually was wondering about it the day before (folder in folder). 😅 |
ah i see, now i also remember @jan--f talking about this :-) lgtm, let's ship |
From k8s version 1.22 the following apiVersions
[1][2]
are no longer served.Hence the PR introduces the following changes
extensions/v1beta1
withapps/v1
authorization.k8s.io/v1beta1
withauthorization.k8s.io/v1
[1]
: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#tokenreview-v122[2]
: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#deployment-v116Signed-off-by: Sunil Thaha sthaha@redhat.com
Fixes #151