Add Makefile target for go dep updates #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's leverage the make target, and update the godeps here as well. Also, please add a section in the readme how to update golang dependencies. |
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
s-urbaniak
reviewed
Jan 6, 2022
Makefile
Outdated
| .PHONY: update-go-deps | ||
| update-go-deps: | ||
| @for m in $$(go list -mod=readonly -m -f '{{ if and (not .Indirect) (not .Main)}}{{.Path}}{{end}}' all); do \ | ||
| go get $$m; \ |
There was a problem hiding this comment.
i believe we want to go get -d, see https://github.com/prometheus/prometheus/blob/b48a1e9e9bc3575e2f6ef3e7ea8573434288e0bb/Makefile.common#L159-L168
according to go help get:
The -d flag instructs get not to build or install packages. get will only
update go.mod and download source code needed to build packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
maketarget for updating go dependencies.Why