check all headers, go version bump #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibihim generally, lgtm. Can you please:
Currently it is not clear what this is fixing, why and how. |
|
yes, thank you. |
ibihim
force-pushed
the
go-version-bump
branch
2 times, most recently
from
4652844
to
d01d218
Compare
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
It is considered problematic, when only the first header value is being authorized and the rest is dropped. It might give the false impression that all given values are authorized. Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Signed-off-by: Krzysztof Ostrowski kostrows@redhat.com