[wip] remove insecure listen address #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
ibihim
force-pushed
the
remove-insecure-listen
branch
from
63bee33
to
825ea12
Compare
|
We can't merge this as is unfortunately, we'd break the CLI API. What we should do instead:
|
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
This was referenced Aug 8, 2022
|
Will be reopened, once we close in on its merge. |
ibihim
changed the title
ibihim
changed the title
|
Will be merged into v1 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offering authn / authz to an insecure server is risky.
The benefits vs risks are easier debugging vs potential for an insecure auth-handling-proxy. The risk outweigh the benefits.
Ref Issue
Signed-off-by: Krzysztof Ostrowski kostrows@redhat.com