Post acceptance use apiserver cert reloader #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
s-urbaniak
reviewed
Aug 18, 2022
| @@ -62,7 +62,6 @@ Usage of _output/kube-rbac-proxy: | |||
| --tls-cipher-suites strings Comma-separated list of cipher suites for the server. Values are from tls package constants (https://golang.org/pkg/crypto/tls/#pkg-constants). If omitted, the default Go cipher suites will be used | |||
| --tls-min-version string Minimum TLS version supported. Value must match version names from https://golang.org/pkg/crypto/tls/#pkg-constants. (default "VersionTLS12") | |||
| --tls-private-key-file string File containing the default x509 private key matching --tls-cert-file. | |||
| --tls-reload-interval duration The interval at which to watch for TLS certificate changes, by default set to 1 minute. (default 1m0s) | |||
There was a problem hiding this comment.
we cannot remove cli flags without prior deprecation.
There was a problem hiding this comment.
we cannot remove cli flags without prior deprecation.
Keep the flag so invocations don't fail. Once you switch to upstream kube fsnotify, you can disconnect the flag from the variable and print a warning that the reload is driven by fsnotify, not by polling.
ibihim
changed the title
|
Will be used to create v1 branch. |
ibihim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use k8s tls reloader.
Why
The mantra of the project is to use k8s logic where ever possible.
Ref
#168