add client cert auth for upstream connections #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
force-pushed
the
client-cert-auth
branch
2 times, most recently
from
5574f4b
to
4ddb68c
Compare
ibihim
reviewed
Nov 30, 2022
stlaz
force-pushed
the
client-cert-auth
branch
2 times, most recently
from
c4e7cd1
to
cfcc0c0
Compare
ibihim
reviewed
Nov 30, 2022
stlaz
force-pushed
the
client-cert-auth
branch
from
cfcc0c0
to
092a1c8
Compare
We would need to find an image that allows testing client cert authentication. I am not currently aware of any, I'll open an issue so that this can be done as a follow-up. |
stlaz
force-pushed
the
client-cert-auth
branch
from
092a1c8
to
74181c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the options to specify client cert/key pair for #169
/assign @ibihim