Minor improvements in cmd/kube-rbac-proxy #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liouk
commented
Jun 7, 2023
| @@ -207,6 +198,7 @@ func Run(opts *completedProxyRunOptions) error { | |||
| handler := identityheaders.WithAuthHeaders(proxy, cfg.KubeRBACProxyInfo.UpstreamHeaders) | |||
| handler = kubefilters.WithAuthorization(handler, authz, scheme.Codecs) | |||
| handler = kubefilters.WithAuthentication(handler, authenticator, http.HandlerFunc(filters.UnauthorizedHandler), cfg.DelegatingAuthentication.APIAudiences) | |||
| // passing an empty RequestInfoFactory results in attaching a non-resource RequestInfo to the context | |||
There was a problem hiding this comment.
@ibihim I'm not sure if I'm missing any other implication of passing an empty RequestInfoFactory, please advise :)
liouk
changed the title
|
Added (11) to the list of addressed issues; converted to Draft while this is WIP. |
ibihim
reviewed
Jun 8, 2023
ibihim
reviewed
Jun 8, 2023
ibihim
requested changes
Jun 8, 2023
ibihim
reviewed
Jun 20, 2023
liouk
force-pushed
the
cmd-minor-improvements
branch
from
6245f7d
to
9398674
Compare
|
LGTM, leaving final ack to @ibihim |
…g within Complete()
…Info and different listeners/ports used
…ter for shutdown signals and use the signal context
liouk
force-pushed
the
cmd-minor-improvements
branch
from
9398674
to
c8fc660
Compare
|
@ibihim after our discussions I've opted for a simple approach to handling the wait groups -- PTAL. I've dropped |
ibihim
reviewed
Jul 3, 2023
| if err := opts.SecureServing.ApplyTo(&proxyConfig.SecureServing); err != nil { | ||
| return nil, err | ||
| if err := wg.Add(1); err != nil { | ||
| cancel() |
There was a problem hiding this comment.
Could you move that into line 242 like so: defer cancel()? Like so:
serverCtx, cancel := context.WithCancel(ctx)
defer cancel()
liouk
force-pushed
the
cmd-minor-improvements
branch
from
c8fc660
to
8953fe1
Compare
ibihim
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues from #238; in particular, the ones listed in this comment.
In particular: