Check errors and log them #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Jan 21, 2019
There was a problem hiding this comment.
Looks good to me. Thanks for the quick fix!
For the future, might be worth adding errcheck.
|
Lgtm and +1 and rungroup, vet, staticcheck etc. |
paulfantom
pushed a commit
to paulfantom/kube-rbac-proxy
that referenced
this pull request
Sep 1, 2020
…cp-baseimages-to-mach-ocp-build-data-config Bug 1872080: Updating Dockerfile.ocp baseimages to mach ocp-build-data config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a server we should check their return values and log them.
Additionally, we should think about using something like
run.Groupto terminate all goroutines if one server fails./cc @brancz @squat @mxinden