validate options: check for secure connection for h2c and identity headers #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibihim
force-pushed
the
secure-connection
branch
4 times, most recently
from
8e3d815
to
85f6c5d
Compare
stlaz
requested changes
Mar 13, 2024
ibihim
force-pushed
the
secure-connection
branch
from
06cb7e8
to
1bd8bc4
Compare
stlaz
reviewed
Mar 15, 2024
ibihim
force-pushed
the
secure-connection
branch
6 times, most recently
from
e17c428
to
c92ca86
Compare
stlaz
reviewed
Mar 25, 2024
ibihim
force-pushed
the
secure-connection
branch
2 times, most recently
from
3f3821b
to
527be50
Compare
stlaz
reviewed
Mar 27, 2024
ibihim
force-pushed
the
secure-connection
branch
from
527be50
to
ee6e3df
Compare
stlaz
reviewed
Mar 28, 2024
ibihim
force-pushed
the
secure-connection
branch
2 times, most recently
from
2fd1f14
to
e1d365c
Compare
stlaz
reviewed
Apr 5, 2024
h2c must happen on a loopback connection as the connection is not using TLS at all. identity headers must use a loopback connection or a mTLS conection is required. Trust in both directions is important. kube-rbac-proxy needs to provide certs, such that upstream can verify the authenticity of the headers. upstream needs certs, such that we can be sure to not leak secrets.
ibihim
force-pushed
the
secure-connection
branch
from
e1d365c
to
876382b
Compare
stlaz
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Check if mTLS or loopback address is provided on h2c or identity headers.
Why
h2c is unencrypted http/2 and we don't want to allow it outside of local connections.
request headers functionality is setting confidential in the headers, we want this to happen only through mTLS. We can't guarantee that upstream verifies client certificates.