Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command line args --kube-api-qps/--kube-api-burst #285

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

novegit
Copy link
Contributor

@novegit novegit commented Mar 18, 2024

Using kube-rbac-proxy in front of a prometheus in a multi tenant environment causes often client-side throttling events, that slow down connections, when more than 10 queries per second are coming in. Only way to mitigate is to increase the number of replicas of the kube-rbac-proxy pods.

Example for client-side throttling:
I0318 12:32:18.188838 800 request.go:629] Waited for 993.646183ms due to client-side throttling, not priority and fairness, request: POST:https://172.30.0.1:443/apis/authorization.k8s.io/v1/subjectaccessreviews
I0318 12:32:18.192938 800 round_trippers.go:553] POST https://172.30.0.1:443/apis/authorization.k8s.io/v1/subjectaccessreviews 201 Created in 3 milliseconds
I0318 12:32:19.189607 800 request.go:629] Waited for 1.994365552s due to client-side throttling, not priority and fairness, request: POST:https://172.30.0.1:443/apis/authorization.k8s.io/v1/subjectaccessreviews

with the new parameters, the queries per second can be set above the default kube-client default value of 10 qps.
--kube-api-qps
--kube-api-burst

@ibihim
Copy link
Collaborator

ibihim commented Mar 18, 2024

@novegit, those are the same flags as used in kube, right?

Cool. Thx for the contribution.

@ibihim
Copy link
Collaborator

ibihim commented Mar 18, 2024

@novegit, nice try 😆 You need to run make generate and commit the README.md changes.

Go / Generate Failed

@novegit
Copy link
Contributor Author

novegit commented Mar 18, 2024

should work now.

@novegit
Copy link
Contributor Author

novegit commented Mar 18, 2024

@novegit, those are the same flags as used in kube, right?

Cool. Thx for the contribution.

yes, on my first try, I only added 'qps'. An error message appeared, that also 'burst' must be set, when 'qps' is set.

@ibihim ibihim merged commit e53dedc into brancz:master Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants