fix bool,deprecated flags regression #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibihim
force-pushed
the
deprecated-flags-regression-fix
branch
from
03e0825
to
247af26
Compare
ibihim
changed the title
liouk
suggested changes
May 7, 2024
| @@ -492,6 +492,10 @@ func Run(cfg *completedProxyRunOptions) error { | |||
| }) | |||
| } | |||
|
|
|||
| if cfg.secureListenAddress == "" && cfg.insecureListenAddress == "" { | |||
There was a problem hiding this comment.
I believe we're most widely using the convention len(somestr) == 0 to check for empty strings.
ibihim
force-pushed
the
deprecated-flags-regression-fix
branch
from
247af26
to
b2e9035
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix a regression for the removed flags.
Why
If the bool value flag was specified like
--logtostderr, without the=true, it was treated like--logtostderr=truein v0.15.0.In v0.16.0 and v0.17.0,
--logtostderrwithout any value would treat the follow up flag as its value, which leads to a regression.