Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the deps to address cves #297

Closed
wants to merge 3 commits into from
Closed

Conversation

njyeti
Copy link

@njyeti njyeti commented May 18, 2024

updated the go deps to the latest to address CVEs mostly for the otel. Those CVEs are CVE-2023-47108, CVE-2023-45142 and CVE-2024-24786 on the head

@njyeti
Copy link
Author

njyeti commented May 18, 2024

My bad! Current commit only addresses CVE-2023-45142 and CVE-2024-24786

@njyeti
Copy link
Author

njyeti commented May 19, 2024

pushed the new commit to fix CVE-2023-47108 as well. We can squash all these commits before merging as well

@ibihim
Copy link
Collaborator

ibihim commented May 27, 2024

That is really great work, but a duplicate to #287

@njyeti
Copy link
Author

njyeti commented May 27, 2024

oh I wasn't aware of that PR. Thanks for pointing that our. Anyway, as long as any of PRs get merged to address the CVEs, I am happy.

@ibihim
Copy link
Collaborator

ibihim commented May 29, 2024

@njyeti, but a great work none the less. I hope to see more contributions in the future 😄

@njyeti
Copy link
Author

njyeti commented May 29, 2024

closing this as #287 is merged

@njyeti njyeti closed this May 29, 2024
@ibihim ibihim reopened this Jun 4, 2024
@ibihim
Copy link
Collaborator

ibihim commented Jun 4, 2024

@njyeti, hey. If you don't mind to create a commit that only contains the deps, I would accept the PR.

I realized that my PR doesn't have otel v0.46 and bumping it started to cause errors. Copy pasting your indirect deps worked fine though, so honor to whom honor is due, if you want to bump go for it!

I would like to fix it within the next days, so if you don't respond, I hope you don't mind that I take over this PR. In that way I can make you contributor indirectly as a co-author.

@njyeti
Copy link
Author

njyeti commented Jun 4, 2024

@ibihim it is just a simple fix, so if the copy paste is working, please go ahead with it. I will be more than happy if the community gets the vul fix. Hopefully, I can contribute in a significant scale in the future instead of just fixing the dependency :)

@ibihim ibihim closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants