Introduce changes from master to sig-auth-acceptance branch #300
+606
−783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibihim
force-pushed
the
sig-auth-acceptance-bump
branch
4 times, most recently
from
f1f64b6
to
ee29cc5
Compare
ibihim
force-pushed
the
sig-auth-acceptance-bump
branch
6 times, most recently
from
7c1476a
to
5c0c8bc
Compare
liouk
suggested changes
Jul 2, 2024
ibihim
force-pushed
the
sig-auth-acceptance-bump
branch
from
5c0c8bc
to
96e75e7
Compare
ibihim
force-pushed
the
sig-auth-acceptance-bump
branch
from
96e75e7
to
c7e1aff
Compare
|
/lgtm |
stlaz
reviewed
Jul 10, 2024
| @@ -232,7 +232,7 @@ func Run(cfg *server.KubeRBACProxyConfig) error { | |||
|
|
|||
| handler := identityheaders.WithAuthHeaders(proxy, cfg.KubeRBACProxyInfo.UpstreamHeaders) | |||
| handler = kubefilters.WithAuthorization(handler, authz, scheme.Codecs) | |||
| handler = kubefilters.WithAuthentication(handler, authenticator, http.HandlerFunc(filters.UnauthorizedHandler), cfg.DelegatingAuthentication.APIAudiences) | |||
| handler = kubefilters.WithAuthentication(handler, authenticator, http.HandlerFunc(filters.UnauthorizedHandler), cfg.DelegatingAuthentication.APIAudiences, nil) | |||
There was a problem hiding this comment.
What happens when you supply the request header nil here? It won't get autodetected from the cluster, right?
| IssuerURL: config.IssuerURL, | ||
| ClientID: config.ClientID, | ||
| tokenAuthenticator, err := oidc.New(ctx, oidc.Options{ | ||
| JWTAuthenticator: apiserver.JWTAuthenticator{ |
There was a problem hiding this comment.
can we remove the old options and just wire the new config, since we have the chance?
| @@ -116,29 +120,30 @@ func (o *ProxyOptions) Validate() []error { | |||
| return errs | |||
| } | |||
|
|
|||
| func (o *ProxyOptions) ApplyTo(c *server.KubeRBACProxyInfo, a *serverconfig.AuthenticationInfo) error { | |||
| func (o *ProxyOptions) ApplyTo(config *server.KubeRBACProxyConfig) error { | |||
There was a problem hiding this comment.
The previous was better in terms of isolation.
There was a problem hiding this comment.
Yes, I know, but I need it to set up HTTP/2 disablement. We can revert it in k8s 1.31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why