Reorder snapshot configmap reconcile to reduce log spew during initia…

…l startup Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond · Nov 17, 2023 · a44c003 · a44c003
1 parent e4c55af
commit a44c003
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/pkg/etcd/snapshot_controller.go b/pkg/etcd/snapshot_controller.go
@@ -158,21 +158,6 @@ func (e *etcdSnapshotHandler) onRemove(key string, esf *apisv1.ETCDSnapshotFile)
 }
 
 func (e *etcdSnapshotHandler) reconcile() error {
-	logrus.Infof("Reconciling snapshot ConfigMap data")
-
-	snapshotConfigMap, err := e.configmaps.Get(metav1.NamespaceSystem, snapshotConfigMapName, metav1.GetOptions{})
-	if err != nil {
-		if !apierrors.IsNotFound(err) {
-			return errors.Wrap(err, "failed to get snapshot ConfigMap")
-		}
-		snapshotConfigMap = &v1.ConfigMap{
-			ObjectMeta: metav1.ObjectMeta{
-				Name:      snapshotConfigMapName,
-				Namespace: metav1.NamespaceSystem,
-			},
-		}
-	}
-
 	// Get a list of all etcd nodes currently in the cluster.
 	// We will use this list to prune local entries for any node that does not exist.
 	nodes := e.etcd.config.Runtime.Core.Core().V1().Node()
@@ -200,6 +185,8 @@ func (e *etcdSnapshotHandler) reconcile() error {
 		return errNotReconciled
 	}
 
+	logrus.Infof("Reconciling snapshot ConfigMap data")
+
 	// Get a list of existing snapshots
 	snapshotList, err := e.snapshots.List(metav1.ListOptions{})
 	if err != nil {
@@ -215,6 +202,19 @@ func (e *etcdSnapshotHandler) reconcile() error {
 		}
 	}
 
+	snapshotConfigMap, err := e.configmaps.Get(metav1.NamespaceSystem, snapshotConfigMapName, metav1.GetOptions{})
+	if err != nil {
+		if !apierrors.IsNotFound(err) {
+			return errors.Wrap(err, "failed to get snapshot ConfigMap")
+		}
+		snapshotConfigMap = &v1.ConfigMap{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      snapshotConfigMapName,
+				Namespace: metav1.NamespaceSystem,
+			},
+		}
+	}
+
 	// Make a copy of the configmap for change detection
 	existing := snapshotConfigMap.DeepCopyObject()